Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sound Mood does not reset to default when there is no character on text event. #1842

Closed
chipolux opened this issue Oct 29, 2023 · 1 comment · Fixed by #1848
Closed

Sound Mood does not reset to default when there is no character on text event. #1842

chipolux opened this issue Oct 29, 2023 · 1 comment · Fixed by #1848
Labels
Bug 🐞 Something isn't working

Comments

@chipolux
Copy link

The problem

Describe the bug
When a text event without a character plays it uses the sound mood from the previously speaking character.

To Reproduce

  1. Set a default sounds folder under Styles -> Sounds -> Typing Sounds
  2. Add a character and add a Typing Sounds -> Mood with different audio than the style default and set it as the characters default sound mood.
  3. To a timeline using the style with typing sounds add 3 text events.
    • The first should have no character (to hear the default typing sound)
    • The second should have the character you set a default sound mood on (to hear the characters sound mood)
    • The third should have no character (to hear the previous characters sound mood continue to be used)
  4. Play the timeline, in engine or using the preview function.

Expected behavior
When no character is speaking the sound mood should revert back to the default that is set for the style.

System (please complete the following information):

  • OS: Windows, macOS
  • Godot Version: 4.1.2.stable
  • Dialogic Version: 2.0-Alpha-10

Solutions

Possible fixes

Adding dialogic.Text.update_typing_sound_mood({}) alongside this line fixes the issue! But I'm not sure if that's the desired way it should work, or if reverting back the default should be explicit in some way (option on the text event/settings).

@Jowan-Spooner
Copy link
Collaborator

Looks like this is a good fix. It should always switch back to the default, no need to make that a setting. Thanks for the report (and providing a fix!)

@Jowan-Spooner Jowan-Spooner added the Bug 🐞 Something isn't working label Oct 29, 2023
@Jowan-Spooner Jowan-Spooner added this to the Version 2.0 (beta) milestone Oct 29, 2023
Jowan-Spooner added a commit that referenced this issue Oct 31, 2023
* Make sure typing sound resets on text without character

- fixes #1842

* Fix #1834

The load_typing_sounds method will now always list imported audio files only and correctly load them when exported.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants