Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error if the first Text Event has no speaker #1998

Closed
CakeVR opened this issue Jan 7, 2024 · 2 comments
Closed

Error if the first Text Event has no speaker #1998

CakeVR opened this issue Jan 7, 2024 · 2 comments
Labels
Bug 🐞 Something isn't working Critical 💩

Comments

@CakeVR
Copy link
Collaborator

CakeVR commented Jan 7, 2024

The problem

Describe the bug
If the first Text Event has no speaker, the following error emerges:
Invalid type in GDScript utility function "load()". Cannot convert argument 1 from Nil to String.

Happened in subsystem_text.gd line 329 using Dialogic 2 Alpha 12.

@CakeVR CakeVR added Bug 🐞 Something isn't working Critical 💩 labels Jan 7, 2024
@CakeVR CakeVR added this to the Version 2.0 (beta) milestone Jan 7, 2024
@Jowan-Spooner
Copy link
Collaborator

This can only happen if you call that method manually. But we should add a default to that get.

@CakeVR
Copy link
Collaborator Author

CakeVR commented Jan 7, 2024

This can only happen if you call that method manually. But we should add a default to that get.

Oh, indeed, I did that for my typewriter. We should add safety defaults to all of these.

Jowan-Spooner added a commit to Jowan-Spooner/dialogic that referenced this issue Jan 7, 2024
Jowan-Spooner added a commit that referenced this issue Jan 9, 2024
* Small fix for StyleLayer resource

* Change empty speaker info to string

* Add method to open history from code

* Change the z_index of simple-highlight-portrait

* Fix Speaker highlight loading

* Fix for #1998

* Attempt at fixing #1993

* Remove old code

* Add "Duplicate" item to event right click

* Finish History open/close methods
Invertex pushed a commit to Invertex/dialogic that referenced this issue Jan 26, 2024
* Small fix for StyleLayer resource

* Change empty speaker info to string

* Add method to open history from code

* Change the z_index of simple-highlight-portrait

* Fix Speaker highlight loading

* Fix for dialogic-godot#1998

* Attempt at fixing dialogic-godot#1993

* Remove old code

* Add "Duplicate" item to event right click

* Finish History open/close methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐞 Something isn't working Critical 💩
Projects
None yet
Development

No branches or pull requests

2 participants