Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save/Load: Text event doesn't allow in-between loading #2028

Closed
Jowan-Spooner opened this issue Jan 18, 2024 · 0 comments
Closed

Save/Load: Text event doesn't allow in-between loading #2028

Jowan-Spooner opened this issue Jan 18, 2024 · 0 comments
Labels
Bug 🐞 Something isn't working Feature✨ Planned This will be worked on soon

Comments

@Jowan-Spooner
Copy link
Collaborator

The text event has the unique ability to seem to the player like multiple events. However this is completely ignored by the save/load system which simply stores the event index (there is no indication of the text events progress in the state). This is perfectly fine for most events, but for a text event with multiple parts, it means it can only begin at the start.

This is especially problematic when you use the "New Lines as New events" setting and use one event block for many events one character says. Saving at any point during those "events" and then loading that save, will always start the event from the beginning (the first text). It is not really a bug, as that is expected, but it's not what users most likely want.

This has only occured to me, because for a rollback system it would also be important to jump into a text event at a specific moment.

I will investigate how to best fix this. Most likely the text event has to update some kind of counter in the current_state to indicate it's own progress. This counter then has to be taken into account when starting any text event.

@Jowan-Spooner Jowan-Spooner added Bug 🐞 Something isn't working Feature✨ Planned This will be worked on soon labels Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐞 Something isn't working Feature✨ Planned This will be worked on soon
Projects
None yet
Development

No branches or pull requests

1 participant