Add sub-Index for mid-text-event loading #2045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a method that clears any remaining connections so we can safely reuse all the event resources.
Does: - allows mid-text event loading (only between sections) - makes sure textbox visibility is correct when loading
Invertex
pushed a commit
to Invertex/dialogic
that referenced
this pull request
Jan 26, 2024
* Clear any remaining event-connections with Timeline.clean() Adds a method that clears any remaining connections so we can safely reuse all the event resources. * Fix and improve text event Does: - allows mid-text event loading (only between sections) - makes sure textbox visibility is correct when loading * Small typo fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first stab at solving #2028 by storing the index of the current text slice, and thus being able to correctly load in the middle of a text event. At least now when using New Lines as New Event option the loading will work correctly.
Also introduces a method that makes sure events in timelines are fully disconnected from any methods. This just makes our lives a bit easier.