Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it configurable where Dialogic adds the layout #2029

Closed
Jowan-Spooner opened this issue Jan 18, 2024 · 0 comments · Fixed by #2048
Closed

Make it configurable where Dialogic adds the layout #2029

Jowan-Spooner opened this issue Jan 18, 2024 · 0 comments · Fixed by #2048
Labels
Approved This can be added, but is not on any roadmap yet Enhance ⚡ Improve a feature's workflow. Feature✨
Milestone
Version 2.0 (beta)

Comments

@Jowan-Spooner
Copy link
Collaborator

This would very much increase the usability I think. And it should be pretty easy to do.

There is two steps to this:

  1. Allow specifying where to add a layout. I think it would still be best to only put this argument on load_style not .start() for simplicity.

  2. Making sure style changes use the same parent as previous styles.

As I said, this is pretty easy to implement (I did it before, locally) I just needed a reminder to actually properly do it at some point.
@Jowan-Spooner Jowan-Spooner added Feature✨ Approved This can be added, but is not on any roadmap yet Enhance ⚡ Improve a feature's workflow. labels Jan 18, 2024
@Jowan-Spooner Jowan-Spooner added this to the Version 2.0 (beta) milestone Jan 25, 2024
Jowan-Spooner added a commit to Jowan-Spooner/dialogic that referenced this issue Jan 25, 2024
@Jowan-Spooner
Allow specifying parent to add layout
6525c59 
- fixes dialogic-godot#2029
@Jowan-Spooner Jowan-Spooner mentioned this issue Jan 25, 2024
Merged
Jowan-Spooner added a commit that referenced this issue Jan 26, 2024
@Jowan-Spooner
Allow specifying parent to add layout (#2048)
ce2a734 
- fixes #2029
Invertex added a commit to Invertex/dialogic that referenced this issue Jan 27, 2024
@Invertex
Squashed commit of the following:
fae7712 
commit 17683f8
Author: Jowan-Spooner <42868150+Jowan-Spooner@users.noreply.github.com>
Date:   Fri Jan 26 18:55:38 2024 +0100

    Rename the Other folder to Core (dialogic-godot#2047)

    * Rename the Other folder to Core

    * Add a small auto-update

    * Fix unit test

commit ce2a734
Author: Jowan-Spooner <42868150+Jowan-Spooner@users.noreply.github.com>
Date:   Fri Jan 26 18:55:03 2024 +0100

    Allow specifying parent to add layout (dialogic-godot#2048)

    - fixes dialogic-godot#2029

commit c33a560
Author: Dabbles in too many things <mitch.zais@gmail.com>
Date:   Fri Jan 26 09:54:52 2024 -0800

    Avoid null get_tree() call (dialogic-godot#2052)

    get_tree() can return null when the Dialogic view isn't open but this function is being called by an external system. No node tree exists to wait for or manipulate, so errors are spammed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Approved This can be added, but is not on any roadmap yet Enhance ⚡ Improve a feature's workflow. Feature✨
Projects
None yet
Milestone
Version 2.0 (beta)
Development

Successfully merging a pull request may close this issue.

Allow specifying parent to add layout Jowan-Spooner/dialogic
1 participant
@Jowan-Spooner