Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popups do not have a close button #2262

Closed
juliohq opened this issue Jun 4, 2024 · 0 comments · Fixed by #2282
Closed

Popups do not have a close button #2262

juliohq opened this issue Jun 4, 2024 · 0 comments · Fixed by #2282
Labels
Enhance ⚡ Improve a feature's workflow. UI/UX ✏

Comments

@juliohq
Copy link
Contributor

juliohq commented Jun 4, 2024

The problem

Describe the bug
Popups do not have a close button so you cannot close them while using a window manager (like i3). Related to #2260.

To Reproduce
Steps to reproduce the behavior:

  1. Cause any popup to show

Expected behavior
Each popup should have a close button somewhere for window manager users to have a button to click.

Screenshots
Just some examples of popups that don't have a close button:

Dialogic Update Checker:
image

Style Browser:
image

System (please complete the following information):

  • OS: Arch Linux (with i3 window manager)
  • Godot Version: v4.2.2
  • Dialogic Version: v2.0-Alpha-14

Solutions

Workaround

N/A

Possible fixes

Add close buttons for popups that don't have one.

Please, could you help me list all popups that don't have a close button in this issue so we could fix all of them in one go?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhance ⚡ Improve a feature's workflow. UI/UX ✏
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Editor UI fixes & improvements Jowan-Spooner/dialogic
2 participants
@juliohq @Jowan-Spooner