Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor UI fixes & improvements #2282

Merged

Conversation

Jowan-Spooner
Copy link
Collaborator

This PR:

  • makes sure the dialogic ui will never go overlap the rest of godot

  • makes the dialogic theme update when the godot theme changes

  • makes the code highlight colors update when the godot theme changes

  • makes the Text events textEdit style follow the TextEditor theme settings, meaning it will work better with custom code color themes

  • adds a ScrollContainer as the root of the character editor to avoid it overlapping the other dialogic UI

  • add custom close buttons to StyleBrowser window and UpdateChecker window

  • fixes Popups do not have a close button #2262

  • fixes Shrinking the editor breaks dialogic UI #2267

This PR:
- makes sure the dialogic ui will never go overlap the rest of godot
- makes the dialogic theme update when the godot theme changes
- makes the code highlight colors update when the godot theme changes
- makes the Text events textEdit style follow the TextEditor theme settings, meaning it will work better with custom code color themes
@Jowan-Spooner Jowan-Spooner added Enhance ⚡ Improve a feature's workflow. UI/UX ✏ labels Jun 17, 2024
@Jowan-Spooner Jowan-Spooner merged commit e9dc737 into dialogic-godot:main Jun 17, 2024
2 checks passed
@Jowan-Spooner Jowan-Spooner deleted the fix-dialogic-ui-overlap branch July 8, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhance ⚡ Improve a feature's workflow. UI/UX ✏
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shrinking the editor breaks dialogic UI Popups do not have a close button
1 participant