Multiple bug fixes + Background Fade improvements #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for If first event is not a TextEvent default text is displayed #1167
Will just reset the text of the dialog text in _ready()
Fix for BackgroundEvent: fade doesn't work on first background? #1188 + Background Fade improvements
Fade now works on the first event. Also you can node implement _fade_in(*time) and _fade_out(*time) on your custom background scenes.
Fix for Singal already connected error when jumping back to where you already were #1166
Added a is_conected() check before connecting
Edit: accidently tagged a user named time.