Character Editor Update #1380
Merged
Character Editor Update #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Autosave on all changes for the character editor This is not optimal, but is a quick fix for the portrait preview not working. Also character resources aren't complex enough to make this a problem I believe. # Move global portrait settings to seperate tab This makes default portrait and main_scale, *_offset and *_mirror part of the character editor again in the portrait section. This makes the editor less crowded.
New portrait settings section "Exports" if a custom portrait scene is selected. This tab shows all the exported variables of that scene and allows to set those. The editor will now also keep the same scene if _should_do_portrait_update is defined and true. This allows blending from one portrait to the other in editor.
- makes sure typing pitch cannot be set to <= 0 by randomness. - forgot to stage the code that actually makes the export overrides work in game
The groups are just a fake representations of portraits named with / in them. So "Emotions/Happy" will be represented as a group Emotions with an item Happy. As this was quite the change from the single level list we had before, many things like searching had to be redone. Search will only look for portrait items (not group items).
Jowan-Spooner
added
Bug 🐞
This was
linked to
issues
Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big features
Groups for portrait list
The portrait list now allows to add groups. These are not actually saved. If a portrait is in a group it will be saved as it's full path (with / e.g.: "Group/Subgroup/Portrait").
You can now also drag and drop to reorder/reparent portrait items.
Custom exports
Custom portrait scenes now have a Export tab in the portrait settings section. If the scenes script has some exported variables, they will be listed there.
For scenes that are in @tool mode, updates can be shown in editor (even with transitions if _should_do_portrait_update() returns true).
These "export_overrides" are saved in the portrait data and applied on change_portrait().
Small changes
--> Note: Most of these were fixed by making the character editor autosave again, as that means the preview can use the character resource to get all information. This instant autosave might not be desired, but isn't to bad for now. In the future, we might want to pass a fake character resource to the preview, not sure.