Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default layout path #1422

Merged

Conversation

QuasiStellar
Copy link
Contributor

In #1421 DialogicDefaultLayout (formerly DialogicDefaultScene) was moved and renamed, however paths pointing to its location were not updated, because GDScript is a very good language and refactoring code written in it is always a pleasure.

There are some occasional formatting fixes to dilute the atmosphere of inevitable hardcoded doom.

@Jowan-Spooner
Copy link
Collaborator

Thanks for this PR.
However, we can now use DialogicUtil.get_default_layout() to get this path. The methods in settings general seem like they are not needed anymore.

@QuasiStellar QuasiStellar force-pushed the fix-default-layout-path branch from f4f55a9 to 065689c Compare February 14, 2023 13:49
@QuasiStellar
Copy link
Contributor Author

Updated and tested with the same usecase.

@Jowan-Spooner Jowan-Spooner merged commit 148fae7 into dialogic-godot:main Feb 14, 2023
@Jowan-Spooner
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants