Expression/Variable update #1486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update is centered around expressions but it has spiraled into much more.
The biggest changes are:
- Set Variable now allows use of expressions
- Set Variable now expects "" around strings
- {Variable Insertion} now allows use of expressions
- Set Variable ui changed, there is now a type selector for the value
- Set Variable random is now an expression
- Condition Picker ui changed, there is now a type selector for both variable and value
- Event resources can now request an update and set a warning
- Both the Set Variable and the Condition/Choice event show an error when using a string incompatible operator with a string.
- The Expression logic in DialogicGameHandler.execute_condition() was generalized and moved into a dedicated subsystem 'Expression'. This one is in a new Core folder together with the End Branch event.
- Autoloads can be accessed again in conditions and set/get variables
- Multiple Event Node fields have been simplified (except condition picker which got much more complicated)
- a bug with condition tangling has been removed
- Icons for "Go to Variable Editor" and "Go to character Editor" have been changed.
- OptionSelector has now a "icon only" mode.
- Warning icon has been better placed.
- Removed nodes have been deleted from the game_ui.tscn
This is because (also to support autoload variables) get_variable() will now execute the given string if no variable could be found for that path. Removed some prints() Fixed an error with float conversion.
You can now escape variables with \ Meaning \{my_variable} will not get replaced. Insert variables also now can contain first level variables allowing stupid shit like:
`Here comes a variable {len({MyVariable})}` or `{{Some Variable}+{Some Other Variable}}`
- fixed the set random mode for visual editor
- fixed more float conversion problems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update is centered around expressions but it has spiraled into much more.
The biggest changes are: