add null check to text update_name_label #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a few places where we do a `update_name_label(null)`, which makes `character.resource_path` throw an invalid index error. This commit fixes this bug; also a fixes a related bug in the same function where it is possible to access `dialogic.current_state_info['character']` before it is defined.
| @@ -87,11 +87,12 @@ func _on_dialog_text_finished(): | |||
|
|
|||
|
|
|||
| func update_name_label(character:DialogicCharacter) -> void: | |||
| if character.resource_path == dialogic.current_state_info['character']: | |||
| var character_path = character.resource_path if character else null | |||
There was a problem hiding this comment.
can you split this into several lines?
|
Merging for now since it fixes the issue :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few places where we do a
update_name_label(null), which makescharacter.resource_paththrow an invalid index error. This commit fixes this bug; also a fixes a related bug in the same function where it is possible to accessdialogic.current_state_info['character']before it is defined.