Add animation support #1547
Merged
Add animation support #1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When opening a visual timeline while another one is still loading (fairly common with longer timelines) the last batch would always still be added to the newly opened timeline. A new check now waits for the last batch of the previous timeline before clearing the timeline.
For most games you want variables to be persistent unless loading a new save. However many things should be reset when a new dialog opens. So I've added clear-flags to the dialogic game handler. These can be used with the clear() method. Most of the time now (at timeline end or dialog start) it won't reset the variables (only at game startup or loading a save). This system should be expandable.
|
Thanks! |
Jowan-Spooner
added a commit
that referenced
this pull request
Jul 29, 2023
Hopefully didn't miss any. Unfortunately this is a giant change.
Jowan-Spooner
added a commit
that referenced
this pull request
Jul 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this is a system where the animations are completely implemented in the layout scene by the user. All they have to do is to call Dialogic.Animation.now_animating() when receiving the signal and call Dialogic.Animation.animation_finished() once done. This way dialogic knows exactly when to continue.
I had to change some things. For example the textboxes now are hidden by default until some text is shown. This can be changed with a setting called "Hide textbox when empty"
This makes scenes with no text much easier. Currently the way to trigger this is to add a wait event that hides the text box. Then it will again only be shown once any text event updates it.
For all of this to work I had to make sure the clear method is called each time a dialog is newly instanced. Unfortunately that meant I had to specify to the clear method what to clear because Variables for example should NOT always be cleared. This introduced a ClearFlags enum on the dialogicgame handler. I hope it's a good addition. It could prove useful in the future.