Addressing Issue #1552 remove auto-pauses #1563
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, this is my first PR so I'm a little bit lost, I hope everything it's okay, tell me if I need to change anything :)
I felt fairly confident I could help with this issue in particular. But as I was approaching it I thought it could've been done in different ways:
I went with the 'D' case, with the 'B' one being the second I like the most. I feel like if the remove button is to the right of the time input I would delete the auto-pause set trying to change the value with the arrows.
Also while addressing this I realized 2 things:
When you add a lot of auto-pauses the UI breaks, I don't think anyone is gonna need that much but maybe is worth to know:
It only saves the auto-pauses when swapping the main tabs:
I'm not sure if that's already known but I wanted to say them in case they aren't