Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing Issue #1552 remove auto-pauses #1563

Merged
merged 5 commits into from
May 20, 2023

Conversation

CristianRos
Copy link
Contributor

Hey, this is my first PR so I'm a little bit lost, I hope everything it's okay, tell me if I need to change anything :)

I felt fairly confident I could help with this issue in particular. But as I was approaching it I thought it could've been done in different ways:

image

I went with the 'D' case, with the 'B' one being the second I like the most. I feel like if the remove button is to the right of the time input I would delete the auto-pause set trying to change the value with the arrows.

Also while addressing this I realized 2 things:

  • When you add a lot of auto-pauses the UI breaks, I don't think anyone is gonna need that much but maybe is worth to know:
    image

  • It only saves the auto-pauses when swapping the main tabs:
    image

I'm not sure if that's already known but I wanted to say them in case they aren't

@Jowan-Spooner
Copy link
Collaborator

Hey, thanks for contributing. I think third option (text input, time input, remove button) makes the most sense.

The autopauses only saving when switching tabs is by design but I would be fine with changing it.

If you feel like it you can add a Scroll container into the settings page to keep it from breaking, but yeah, so many pauses are unlikely.

@Jowan-Spooner Jowan-Spooner linked an issue May 20, 2023 that may be closed by this pull request
@CristianRos
Copy link
Contributor Author

I don't feel confident enough about touching the saving part, I mentioned it because I kind of thought it would save changes directly and I was struggling a bit thinking I introduced a bug or something like that haha

But I changed what you said, now the autopauses follow [text input, time input, remove button] and there is a scroll bar when you add a lot of them.

Hope that's okay!

This happens all the time. Probably not even that bad a thing, but I dislike these humongus glyph caches.
@Jowan-Spooner Jowan-Spooner merged commit 53ca34c into dialogic-godot:main May 20, 2023
@Jowan-Spooner
Copy link
Collaborator

Looks great! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is no way to remove Auto-pauses
2 participants