Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this somewhat fixes a particular bug I've experienced in text handling, in which as far as i can tell:
dialogic_default_action
on the same frame they also trigger another input action (say, moving the mouse)_input
is called for thedialog_default_action
,dialogic_default_action
has been pressed this frame, so the coroutine to advance text (handle_event
) starts_input
is called for the other action,dialogic_default_action
has been pressed this frame, so the coroutine to advance text starts againi believe this PR fixes the input situation, but the race condition still probably exists. i don't understand how godot godot coroutines work well enough to tell if it's actually an issue, though.