Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make code completion helper and syntax highlighter global #1697

Merged
merged 4 commits into from
Aug 31, 2023

Conversation

Jowan-Spooner
Copy link
Collaborator

  • previously each text event had it's own code completion helper and syntax highlughter. The first is now a global node (child of EditorsManager) the second a shared resource.
    Hopefully this makes loading faster @exelia will have to test that though.

Hopefully this makes loading faster @Exilia will have to test that though.
@Jowan-Spooner Jowan-Spooner added Bug 🐞 Something isn't working Feature✨ labels Aug 29, 2023
@Jowan-Spooner Jowan-Spooner merged commit 42bd66e into main Aug 31, 2023
## TODO remove this once https://github.com/godotengine/godot/issues/38560 is fixed
if mode != Modes.FULL_HIGHLIGHTING:
return

# make sure shortcode event references are loaded
if mode == Modes.FULL_HIGHLIGHTING:
var hidden_events :Array= DialogicUtil.get_editor_setting('hidden_event_buttons')
var hidden_events :Array= DialogicUtil.get_editor_setting('hidden_event_buttons', [])
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this and everything you do! It's a big help!

I was getting a frequent error when typing, so I'm glad to see the fix is in main as well!

Screenshot from 2023-09-12 17-03-25

@Jowan-Spooner Jowan-Spooner deleted the make-syntax&completion-global branch October 7, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐞 Something isn't working Feature✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants