Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple small features & fixes #1763

Merged
merged 5 commits into from
Oct 2, 2023
Merged

Multiple small features & fixes #1763

merged 5 commits into from
Oct 2, 2023

Conversation

Jowan-Spooner
Copy link
Collaborator

@Jowan-Spooner Jowan-Spooner commented Sep 29, 2023

@Jowan-Spooner Jowan-Spooner added Bug 🐞 Something isn't working Feature✨ labels Sep 29, 2023
@CakeVR
Copy link
Collaborator

CakeVR commented Sep 29, 2023

I found the following problem, which is a warning for people testing this:

When I added an Auto-Pause, Dialogic will report:
Invalid get index 'text_speed' (on base: 'Node (subsystem_settings.gd)').

Reproduction of this bug:

  1. Add an arbitrary string - e.g. "." - with an arbitrary time delay.
  2. Disable Absolute auto-pause timers.
  3. Run a sentence containing ".".

This bug gets fixed by my pull request: #1755

@Jowan-Spooner
Copy link
Collaborator Author

When I added an Auto-Pause, Dialogic will report:
Invalid get index 'text_speed' (on base: 'Node (subsystem_settings.gd)').

@CakeVR I pushed a fix for this. When we merge the autoadvance PR we can choose your fix or this one, idc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐞 Something isn't working Feature✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supporting line breaks within choice boxes
2 participants