Add Character Name Translation #1898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jowan-Spooner
approved these changes
Nov 27, 2023
…akeVR/dialogic into add-character-name-translation
They duplicated if there were multiple timelines referencing characters.
- Fixed translated nicknames method complaining about PackedStringArray (godot being stupid) - Fixed event translations being compared to incorrect key for fallback.
Invertex
pushed a commit
to Invertex/dialogic
that referenced
this pull request
Jan 26, 2024
* Generate translation for character names. * Add property translation to `DialogicCharacter`. * Fix property key. * Improve counting CSV updates and additions. * Improve `Update CSV files` status message. * Add check if `current_resource` is not `null`. * Fix file paths for characters and `Per Timeline` mode. * Refactor CSV and translation deletion. * Fix using wrong default name for character CSV. * Lock Translation Settings if CSV were generated. * Improve deletion of CSV related items. * Hide dialogue window. * Improve Translation Settings text. * Add info about deleting translation IDs. * Use translated character nicknames. * Add missing type. * Remove unused variable. * Add missing newlines. * Remove redundant `await`. * Add `get_display_name_translated`. * Check if event has `character`. * Add type Godot cannot infer. * Fix `characters` variable exist check. * Update method usage. * Check if translation is translation key. * Fix check if translation is translation key. * Fix duplicates of character properties in the CSV. They duplicated if there were multiple timelines referencing characters. * Fix word. * Fix handling timeline CSV collecting. * Small fixes for character line collection * Fix two translation bugs - Fixed translated nicknames method complaining about PackedStringArray (godot being stupid) - Fixed event translations being compared to incorrect key for fallback. * Fix closing and opening editor timeline on deletion. --------- Co-authored-by: Jowan-Spooner <raban-loeffler@posteo.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the feature of automatically generating character translations.
The properties supported are:
display_namenicknamesSteps to do: