Alternative Background Transition Implementation #1952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also tries but fails to implement some transitions.
Pheubel
reviewed
Dec 15, 2023
Invertex
pushed a commit
to Invertex/dialogic
that referenced
this pull request
Jan 26, 2024
* create first pass transition resource * added rough editor for transitions * background event should have access to transitions * fixed spelling mistake * fixed layout i broke earlier * in functioning state * allow for custom defaults for transitions * make sure that texture stays centered when scaled * Simplify background transition system * Add special_resources system for PortraitAnimations and Transitions Also tries but fails to implement some transitions. * Fix transitions, add new transition * Some more default transitions * Make sure "is DialogicBackground" check is done before required --------- Co-authored-by: Pheubel <luca.guagliardo@live.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @Pheubel's #1942 but quite modified.
Introduces a new "special_resources" system that allows modules to define some files they want to collec and can then easily access via the ResourceUtil. This is now used by both the portrait animations and background transitions. This should allow to limit the amount of methods needed on the indexer_class.
Also adds a bunch of background transitions all inheriting from DialogicBackgroundTransition, very similar to DialogicAnimation in how it works.