Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty-choice-indentation bug #1991

Conversation

Jowan-Spooner
Copy link
Collaborator

Reported by a user on discord, having an empty choice before an indentation change would incorreclty calculate the amount of end branches needed.

Example timeline of failure:

if {RedWandCount} > 0 or {BlueWandCount} > 0 or {GreenWandCount} > 0:
	The pedestal is empty.
	- Place red wand [if {RedWandCount} > 0][else="hide"]
	- Place blue wand [if {BlueWandCount} > 0][else="hide"]
	- Place green wand [if {GreenWandCount} > 0][else="hide"]
else:
	The pedestal is empty and you can't do anything about it.
The end
[end_timeline]

Would fail previously, but now works.

Reported by a user on discord, having an empty choice before an indentation change would incorreclty calculate the amount of end branches needed.
@Jowan-Spooner Jowan-Spooner added the Bug 🐞 Something isn't working label Jan 5, 2024
@coppolaemilio coppolaemilio merged commit bb6b22f into dialogic-godot:main Jan 6, 2024
2 checks passed
@coppolaemilio
Copy link
Collaborator

Thanks!

@Jowan-Spooner Jowan-Spooner deleted the fix-empty-choice-indentation-bug branch January 18, 2024 13:27
Invertex pushed a commit to Invertex/dialogic that referenced this pull request Jan 26, 2024
Reported by a user on discord, having an empty choice before an indentation change would incorreclty calculate the amount of end branches needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants