Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quick-open to timeline editors #2018

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Add quick-open to timeline editors #2018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions addons/dialogic/Editor/Events/Fields/field_options_dynamic.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ enum Modes {PURE_STRING, PRETTY_PATH, IDENTIFIER}
@export var fit_text_length := true
var collapse_when_empty := false
var valid_file_drop_extension := ""
var get_suggestions_func : Callable
var get_suggestions_func: Callable

var resource_icon : Texture = null:
var resource_icon: Texture = null:
get:
return resource_icon
set(new_icon):
Expand Down Expand Up @@ -45,6 +45,7 @@ func _set_value(value:Variant, text:String = '') -> void:
current_value = str(value)



func _load_display_info(info:Dictionary) -> void:
valid_file_drop_extension = info.get('file_extension', '')
collapse_when_empty = info.get('collapse_when_empty', false)
Expand Down Expand Up @@ -114,8 +115,8 @@ func _on_Search_text_changed(new_text:String, just_update:bool = false) -> void:

var suggestions: Dictionary = get_suggestions_func.call(new_text)

var line_length:int = 0
var idx:int = 0
var line_length: int = 0
var idx: int = 0
for element in suggestions:
if new_text.is_empty() or new_text.to_lower() in element.to_lower() or new_text.to_lower() in str(suggestions[element].value).to_lower() or new_text.to_lower() in suggestions[element].get('tooltip', '').to_lower():
line_length = max(get_theme_font('font', 'Label').get_string_size(element, HORIZONTAL_ALIGNMENT_LEFT, -1, get_theme_font_size("font_size", 'Label')).x+80, line_length)
Expand All @@ -132,7 +133,6 @@ func _on_Search_text_changed(new_text:String, just_update:bool = false) -> void:
if not %Suggestions.visible:
%Suggestions.show()
%Suggestions.global_position = $PanelContainer.global_position+Vector2(0,1)*$PanelContainer.size.y
#%Suggestions.position = Vector2()
%Suggestions.size.x = max(%Search.size.x, line_length)
%Suggestions.size.y = min(%Suggestions.get_item_count()*35*DialogicUtil.get_editor_scale(), 200*DialogicUtil.get_editor_scale())

Expand Down Expand Up @@ -203,6 +203,16 @@ func _on_search_gui_input(event: InputEvent) -> void:
%Suggestions.select(current_selected)
%Suggestions.ensure_current_is_visible()

if Input.is_key_pressed(KEY_CTRL):
if event is InputEventMouseButton and event.pressed and event.button_index == MOUSE_BUTTON_LEFT:
if valid_file_drop_extension in [".dch", ".dtl"] and not current_value.is_empty():
EditorInterface.edit_resource(DialogicResourceUtil.get_resource_from_identifier(current_value, valid_file_drop_extension))

if valid_file_drop_extension in [".dch", ".dtl"] and not current_value.is_empty():
%Search.mouse_default_cursor_shape = CURSOR_POINTING_HAND
else:
%Search.mouse_default_cursor_shape = CURSOR_IBEAM


func _on_search_focus_entered() -> void:
if %Search.text == "" or current_value == "":
Expand Down
9 changes: 9 additions & 0 deletions addons/dialogic/Editor/TimelineEditor/TextEditor/CodeCompletionHelper.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,10 +274,19 @@ func symbol_lookup(symbol:String, line:int, column:int) -> void:
if symbol in shortcode_events.keys():
if !shortcode_events[symbol].help_page_path.is_empty():
OS.shell_open(shortcode_events[symbol].help_page_path)
if symbol in DialogicResourceUtil.get_character_directory():
EditorInterface.edit_resource(DialogicResourceUtil.get_resource_from_identifier(symbol, 'dch'))
if symbol in DialogicResourceUtil.get_timeline_directory():
EditorInterface.edit_resource(DialogicResourceUtil.get_resource_from_identifier(symbol, 'dtl'))


# Called to test if a symbol can be clicked
func symbol_validate(symbol:String, text:CodeEdit) -> void:
if symbol in shortcode_events.keys():
if !shortcode_events[symbol].help_page_path.is_empty():
text.set_symbol_lookup_word_as_valid(true)
if symbol in DialogicResourceUtil.get_character_directory():
text.set_symbol_lookup_word_as_valid(true)
if symbol in DialogicResourceUtil.get_timeline_directory():
text.set_symbol_lookup_word_as_valid(true)

Loading