Fix variable and setting nodes not updating on type change #2068
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2067
Fixes #2062 (Uses the proposed change in the issue)
May also fix #2063 , since I suspect a null value might be the product of the visual editor not generating the correct code
Changes
event_variable
andevent_settings
to use enums for their different value types to make the code easier to readevent_block
to not callset_value
on fields that are not visible. This prevents invisible fields from throwing errors when they get injected with the wrong data type in event nodes that have varying value types (such asevent_variable
andevent_settings
, whose value types can be strings, numbers, expressions, etc.)