-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve portrait positions and position event #2123
Merged
Jowan-Spooner
merged 28 commits into
dialogic-godot:main
from
Jowan-Spooner:portrait-position-updates
Jun 20, 2024
Merged
Improve portrait positions and position event #2123
Jowan-Spooner
merged 28 commits into
dialogic-godot:main
from
Jowan-Spooner:portrait-position-updates
Jun 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Positions can now have a list of identifiers.
- improve VN portrait layer (better spacing) - improve Shortcode Event save/load code. - can now Save, whether a shortcode had been set. - allow shortcode values to contain = but not unescaped " - Implement multitween (allowing multiple tweens to contribute to the same property) - Implement container movement, rotation and resizing - Add "position-suggestions" field in Portrait settings - Improve position event - adds translation, rotation, resize - adds tweening settings (ease/trans/await) - Add a debug draw mode for PortraitContainers
Jowan-Spooner
added
Enhance ⚡
Improve a feature's workflow.
Feature✨
Needs testing
More feedback/testing would be good
labels
Mar 3, 2024
Seems to work at least somewhat. Needs a lot of further testing.
This PR attempts to fix the fact that loading would be called twice, because the style attempted to reload from the current state. This is only sometimes desired, so now Styles.load_style() will NOT reload content by default, while a new helper method change_style() (which just calles load_style() behind the scenes) DOES reload content by default. This means this can still happen but should not happen if used correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings big changes to the way portrait positions work. Containers now can have multiple identifiers, and importantly identifiers can be strings, meaning you can now specify positions as "left","center", etc.
The containers in the PortraitLayer are now only used as "presets", but when a character is joined it actually get's its own container. You can now also specify a position, size and rotation directly on the character event instead of a premade position. This makes the portrait event pretty unnecessary. I'll still have to decide whether it should be removed or not.
This is also importantly COMPATIBILITY BREAKING in numberous ways:
This PR attempts to fix the fact that loading would be called twice, because the style attempted to reload from the current state. This is only sometimes desired, so now Styles.load_style() will NOT reload content by default, while a new helper method change_style() (which just calles load_style() behind the scenes) DOES reload content by default. This means this can still happen but should not happen if used correctly.
Small side-adjustments:
_should_do_portrait_update
return false by default, otherwise fade doesn't work which feels strange.position
variable renamed totransform
to make it more clear what it now means