don't emit Dialogic.timeline_ended
until Timeline#clean
has been called
#2146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes a bug where starting a timeline in a callback attached to
Dialogic.timeline_ended
will lock, sinceTimeline#clean
fires a frame after it's called (and aftertimeline_ended
is emitted), which will then disconnect the signals on the new timeline.(easy repro:
causes the timeline to run once, and then to start a second time without input working.)