Text Reveal Skippable Potential Fix #2183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Text Reveal Skippable` doesn't trigger at the very first dialogue text that appears. This fixes that by connecting the signals in `DialogicGameHandler` (timeline_started(), timeline_ended(), and state_changed()) to `event_text.gd`. This fixes unintended behaviours where unskippable texts somehow got skip, and player getting stuck waiting for the remainder of `Text Reveal Skippable Delay` to finish even though texts is already finished (This one is an edge case).
Jowan-Spooner
added a commit
that referenced
this pull request
Apr 18, 2024
- should replace #2183 Thanks so much to @StrangeLost to bringing this to my attention and providing a MRP! - uses is_action_JUST_pressed for input handling, avoiding issues where by having the mouse pressed and moving while advancing, you could trigger advance twice. - move skip delay blocking to the beginning of text events - expose "Advance Delay" - cleanup text settings scene/script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Text Reveal Skippabletimer doesn't trigger at the very first dialogue text that appears, and to dialogues right after a choice. This fixes that by connecting the signals inDialogicGameHandlertimeline_started(),timeline_ended(), andstate_changed()toevent_text.gd.This fixes unintended behaviours where supposedly unskippable texts somehow got skip, and player getting stuck waiting for the remainder of
Text Reveal Skippable Delayto finish even though texts is already finished (This one is an edge case, for example if your delay timer is above 3s or 5s).