Fix to autoskip and wait event pausing #2214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were not working correctly because autoskip did a has_subsystem check before the history subsystem was initialized.
This might be breaking things for people who use the scene tree pausing for dialog, but that's just a bad use of it.
Jowan-Spooner
added
Bug 🐞
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix autoskip enable_on_visited and disable_on_unread_text
These were not working correctly because autoskip did a has_subsystem check before the history subsystem was initialized.
Make sure wait event timer stops when scene tree is paused
This might be breaking things for people who use the scene tree pausing for dialog, but that's just a bad use of it.