Update subsystem history. #2233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update variable type for _result instead of letting the engine guessing the type.
|
Tbh I would prefer just removing the _result capturing. I think Cake added this, because they enabled very rigorous godot warnings, but I truly feel that at that point it's messing with the readability of the code if we were to actually capture the "result" everytime we connect a signal. |
|
Totally forgot that you made this request. Thank you |
|
Np ;) Thank YOU! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone, did you miss me?
Update variable type for _result instead of letting the engine guessing the type.
For some reason in 4.3 (godotengine/godot#92021 probably) can't guess the type of that very specific line, maybe because can't even parse the referenced class so it just throw it as variant and let it work until fails?
This kinda works (as is just a solution in place that solved Emi traceback). Tested with https://github.com/dialogic-godot/test-project exporting to linux, using Godot v4.3.dev6.official [64520fe67].
It may fix #2231 ? I'm not sure, that traceback seems more related to Editor* classes being referenced in exported game