Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export follow_viewport for default layout base #2309

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

juliohq
Copy link
Contributor

@juliohq juliohq commented Jun 24, 2024

This PR adds a follow_viewport property that is able to be changed through the layer settings under the styles tab. follow_viewport sets follow_viewport_enabled for CanvasLayer layout base scenes.

@Jowan-Spooner
Copy link
Collaborator

This is a simple feature, so I don't really mind, but could you elaborate when this would be useful? Is it a common thing to need? I guess it could be used on text-bubble like layouts, but those use a different base layer anyways?

@juliohq
Copy link
Contributor Author

juliohq commented Jun 24, 2024

That will make it possible for the text box to be positioned on top of the character manually via code (without being anchored to a specific corner of the screen). Think of something similar to the textbubble style:

image

@Jowan-Spooner
Copy link
Collaborator

Sure. I really don't want to bloat this scene because if you really want anything custom from it it's SO easy to make a custom version, but I don't mind adding this if you feel it's useful.

@juliohq
Copy link
Contributor Author

juliohq commented Jun 24, 2024

I believe that's very useful since you'll be able to configure that option through the style settings. I think that's also in line with the layer setting that exists in the scene script alredy.

@Jowan-Spooner Jowan-Spooner merged commit e96370e into dialogic-godot:main Jun 24, 2024
2 checks passed
@juliohq juliohq deleted the export-follow-viewport branch June 25, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants