Editor UI: More sidebar improvements #2409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes a lot of duplicate code. Makes the "Path" mode truncate folder names when unnecessary. Makes the folder colors inherit like in the file system.
Allows toggeling the use of folder colors and folder name truncation. Renames the sorting to grouping (in case sorting gets a separate control in the future) Makes it so the V-Split (between the resource list and the content list) is remembered across sessions.
|
@Jowan-Spooner Looks great to me! 👍 |
Jowan-Spooner
added
the
Approved
zaknafean
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow up to #2350 this does some code cleanup and modifies the sorting drop-down into an options popup that allows to introduce more settings in the future.
It also improves the folder color logic and trimming of file paths to the necessary length (both optional now).