Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skippable option to Wait event #2439

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

salianifo
Copy link
Contributor

@salianifo salianifo commented Oct 15, 2024

Closes: #1029

Added a skippable option to the wait event. Default value is false. I don't think that the is_instance_valid is needed for the if _is_instance_valid(_tween): but I put it there just in case.

@Jowan-Spooner Jowan-Spooner added the Approved This can be added, but is not on any roadmap yet label Oct 15, 2024
@zaknafean zaknafean self-requested a review October 16, 2024 20:19
Copy link
Collaborator

@zaknafean zaknafean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good extension of the wait event without messing with the point of it.

@zaknafean zaknafean merged commit c4227bd into dialogic-godot:main Oct 16, 2024
2 checks passed
@salianifo salianifo deleted the skippable-waits branch October 16, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved This can be added, but is not on any roadmap yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Wait Event
3 participants