Add Event class #871
Add Event class #871
Conversation
Event class is based on EventSystem's Event class. You can see its implementation on https://github.com/AnidemDex/Godot-EventSystem Using 1.4.3 version. Some deprecated members were removed directly, but those that will not be used by the plugin remains untouched.
|
Note: For some reason I can't mark this PR as WIP |
|
Don't worry, I won't merge until we think it's ready ;) |
| emit_changed() | ||
|
|
||
|
|
||
| func _set_event_node_path(value:NodePath) -> void: |
There was a problem hiding this comment.
@AnidemDex por que haces el setget en este tipo de propiedades?
There was a problem hiding this comment.
Los recursos necesitan notificar de alguna forma a los objetos que les usan que fueron modificados. Implemento los setter para hacer la notificación
| ## The event hint that'll be displayed when you hover the event button in the editor. | ||
| var event_hint:String = "" | ||
|
|
||
| var event_category:String = "Custom" |
There was a problem hiding this comment.
@AnidemDex veo que esto es una string ahora pero me preocupa porque no sería fácil de traducir en un futuro. Tienes pensado algo en particular para las categorías?
There was a problem hiding this comment.
Es un String cualquiera. Hay un nodo (CategoryManager) quien es quien crea las categorías y los botones. Así que esa cadena puede traducirse antes de crear la categoría
This is part of #869 wich adds Event class script.
I'll try to connect this class with timeline editor, but if I don't find an easy way to do it, I'll just change the timeline editor load behaviour