Event and timeline improvements for 2.0 #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also had to update the ResourcePicker to work with portraits. I've also added a new method that "Settings Scenes" (those that show a property of the event) can implement called `react_to_change`. If they have a event_resource variable, it will also be set to the one of the event so you can check for other properties. This allows the "portrait picker" to hide if there is no character selected. Also added that Documentation links are actually opened in the browser. Only the text event has one yet. Also moved the `identify_event()` function into the DialogicUtil, so it can be used by other scripts as well.
Currently they are saved as a dictionary. This might change depending on our implmentation of portraits. The two examples characters have been updated as well as the timelines. Also fixed the tooltip of the Add Character button.
Removes a number of unnecessary variables and functions of the TimelineEditor. Changes the `get_events_indexed()` and `add_events_indexed()` and `copy_selected_events()` so copying and duplicating work again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1: Portrait Picker + Documentation + identify_event() -> DialogicUtil.get_event_by_string()
Also had to update the ResourcePicker to work with portraits.
I've also added a new method that "Settings Scenes" (those that show a property of the event) can implement called
react_to_change. If they have a event_resource variable, it will also be set to the one of the event so you can check for other properties. This allows the "portrait picker" to hide if there is no character selected.Also added that Documentation links are actually opened in the browser. Only the text event has one yet.
Also moved the
identify_event()function into the DialogicUtil, so it can be used by other scripts as well and renamed it to get_event_by_string().Part 2
Currently they are saved as a dictionary. This might change depending on our implmentation of portraits.
The two examples characters have been updated as well as the timelines.
Also fixed the tooltip of the Add Character button.
Part 3
Removes a number of unnecessary variables and functions of the TimelineEditor.
Changes the
get_events_indexed()andadd_events_indexed()andcopy_selected_events()so copying and duplicating work again.