Dialogic 2.0: Condition event and folding (and more) #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tried to make it as simple as possible. Basically: - EventNode has a new collapsed flag and a new toggle button. The button only shows, if a end_node is set. - TimelineEditor.indent_events checks if an event is set to collapsed. If so all nodes until the end node of that event will be hidden.
# Condition event Adds a new condition event. Conditions can be anything the Expression class can parse INCLUDING methods. Currently you can not use variables oc and there is only a text input. Conditions should work as expected in game, but I could be wrong. # Fixed the undo command a bit You can now delete and undo the deletion again. Duplication, copy/paste/cut are on the todo list. # Other stuff - added a timeline_ended signal to the DialogicGameHandler and made the preview scene hide on timeline end - updated the single-line style to be the same as the resource picker. not optimal, but better looking than before. Sorry UI/UX is not my concern right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Condition event
Adds a new condition event. Conditions can be anything the Expression class can parse INCLUDING methods. Currently you can not use variables oc and there is only a text input.
Conditions should work as expected in game, but I could be wrong.
Event folding
The condition and choice event can now be folded. The hiding logic is done in
TimelineEditor.indent_events(). More info in the commit.Fixed the undo command a bit
You can now delete and undo the deletion again. Duplication, copy/paste/cut are on the todo list.
Other stuff