2.0 Jump + Label, Event Button Sorting #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reimplements the goto and label functionality. GoTo only allows to jump inside the timeline, while change timeline now has a label settings as well, that allows to start the given timeline at a specific point. Alternatively you can also specify a label when starting a timeline in code by doing DialogicGameHandler.start_timeline(resource, label). The label is optional though. The event icons are a bit to big. Emilio should fix that.
Added class names to the events that were missing one. Implemented button sorting again.
The new jump event is basically a Change timeline event with a label selector. If no timeline is selected (or the current one), it will just jump to a label with the name inside the current timeline.
Jowan-Spooner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jump/Label
This reimplements the label functionality. The Jump event is a modification of the Change timeline. If no timeline is selected, it will jump to a label with the name in the current timeline.
Alternatively you can also specify a label when starting a timeline in code by doing
DialogicGameHandler.start_timeline(resource, label). The label is optional though.The event icon is a bit to big. Emilio should fix that.
Other