Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0 Add Music and Sound event (+Textbox auto size) #939

Merged

Conversation

Jowan-Spooner
Copy link
Collaborator

Adds a music and a sound event that are fully functional from what I can tell.
They both have looping functionality, but as there is currently no way of stopping a started sound (except it ending) I've hidden it on the sound event
This includes two new "display nodes" the MusicPlayer and SoundPlayer.

Notes

  • changed the event body to a flex container, so settings are displayed in the most space-saving way automatically.
    -> had to reimplement the auto-sizing for the text box input

  • added a new boolean input for the event node

  • adds a decibel mode to the number input

  • the icons of the new events are still a bit to big

Adds a music and a sound event that are fully functional from what I can tell. 

This includes two new "display nodes" the MusicPlayer and SoundPlayer.

# Notes
- changed the event body to a flex container, so settings are displayed in the most space-saving way automatically.
-> had to reimplement the auto-sizing for the text box input

- added a new boolean input for the event node
- adds a decibel mode to the number input 
- the icons of the new events are still a bit to big
@coppolaemilio coppolaemilio merged commit ef47307 into dialogic-godot:version-2.0 Jun 23, 2022
@Jowan-Spooner Jowan-Spooner deleted the music_sound_and_tx branch December 26, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants