Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

build: dialtone vue styles #936

Merged
merged 3 commits into from
Aug 15, 2023
Merged

build: dialtone vue styles #936

merged 3 commits into from
Aug 15, 2023

Conversation

juliodialpad
Copy link
Contributor

Description

Added dialtone-vue style.css into dialtone.css so clients don't need to import two different stylesheets. This also helps to avoid conflicts as dialtone-vue styles should always override dialtone's.

Pull Request Checklist

  • Ask the contributors if a similar effort is already in process or has been solved.
  • Review the contribution guidelines.
  • Use staging as your pull request's base branch. (All PRs using production as its base branch will be declined).
  • Ensure all gulp scripts successfully compile.
  • Update, remove, or extend all affected documentation.
  • Ensure no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).

Obligatory GIF (super important!)

@github-actions
Copy link
Contributor

✔️ Deploy Preview ready!
😎 Browse the preview: https://dialpad.design/deploy-previews/pr-936
🔨 If you experience an SSL issue then wait 2 minutes and try again.

Copy link
Contributor

@iropolo iropolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@juliodialpad juliodialpad merged commit 3118140 into staging Aug 15, 2023
@juliodialpad juliodialpad deleted the feat/dialtone-vue-styles branch August 15, 2023 16:26
@github-actions
Copy link
Contributor

🎉 This PR is included in version 8.13.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

juliodialpad added a commit that referenced this pull request Oct 20, 2023
juliodialpad added a commit that referenced this pull request Oct 20, 2023
juliodialpad pushed a commit that referenced this pull request Oct 20, 2023
yorbi-dp pushed a commit that referenced this pull request Oct 23, 2023
yorbi-dp pushed a commit that referenced this pull request Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants