Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

docs(icon): remove deprecated svg icons #966

Merged
merged 4 commits into from
Oct 6, 2023

Conversation

francisrupert
Copy link
Collaborator

Description

/c @fede-dp, @yorbi-dp

The Design Language > Iconography page's content is effectively deprecated, though it ultimately will be replaced with documentation that provides an overview of the icon style, while access to the complete Icon library remains at Components > Icon component.

This temporarily suppresses access to Design Language > Iconography and labeled as "Planned" on Design Language.

Pull Request Checklist

  • Ask the contributors if a similar effort is already in process or has been solved.
  • Review the contribution guidelines.
  • Use staging as your pull request's base branch. (All PRs using production as its base branch will be declined).
  • Ensure all gulp scripts successfully compile.
  • Update, remove, or extend all affected documentation.
  • Ensure no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).

image

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

✔️ Deploy Preview ready!
😎 Browse the preview: https://dialpad.design/deploy-previews/pr-966
🔨 If you experience an SSL issue then wait 2 minutes and try again.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

✔️ Deploy Preview ready!
😎 Browse the preview: https://dialpad.design/deploy-previews/pr-966
🔨 If you experience an SSL issue then wait 2 minutes and try again.

Copy link
Contributor

@iropolo iropolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approved.
Looks goods, thanks.

@francisrupert francisrupert merged commit 8dfc6af into staging Oct 6, 2023
@francisrupert francisrupert deleted the docs/remove-deprecated-svg-icons branch October 6, 2023 17:49
braddialpad pushed a commit that referenced this pull request Oct 6, 2023
## [8.18.1](dialpad/dialtone@v8.18.0...v8.18.1) (2023-10-06)

### Bug Fixes

* **Root Layout:** update dialtone to fix root-layout on docsite ([#969](https://github.com/dialpad/dialtone/issues/969)) ([38b0103](dialpad/dialtone@38b0103))

### Documentation

* **Icon:** remove deprecated svg icons ([#966](https://github.com/dialpad/dialtone/issues/966)) ([8dfc6af](dialpad/dialtone@8dfc6af))
* storybook access from header ([#965](https://github.com/dialpad/dialtone/issues/965)) ([d61666f](dialpad/dialtone@d61666f))
* update dialtone-vue ([eea5609](dialpad/dialtone@eea5609))
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

🎉 This PR is included in version 8.18.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants