fix(lint): NO-JIRA fix linter rule for text styles #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninamarina
requested review from
juliodialpad,
iropolo,
francisrupert and
braddialpad
as code owners
juliodialpad
approved these changes
Sep 11, 2024
packages/eslint-plugin-dialtone/lib/rules/recommend-typography-style.js
Outdated
Show resolved
Hide resolved
…-style.js Co-authored-by: Julio Ortega <julio.ortega@dialpad.com>
|
✔️ Deploy previews ready! |
juliodialpad
pushed a commit
that referenced
this pull request
Sep 11, 2024
## [9.72.3](dialtone/v9.72.2...dialtone/v9.72.3) (2024-09-11) ### Bug Fixes * **Lint:** NO-JIRA fix linter rule for text styles ([#494](#494)) ([c6b5f3f](c6b5f3f)) * **Scrollbar Directive:** NO-JIRA overlayscrollbars missing styles ([#493](#493)) ([d1a88e1](d1a88e1)) * **Tokens:** NO-JIRA keep references in css output ([#487](#487)) ([b019ff6](b019ff6)) ### Documentation * **Icon:** DLT-1916 update documentation to show tree shaking examples ([#491](#491)) ([5b9d969](5b9d969))
juliodialpad
pushed a commit
that referenced
this pull request
Sep 11, 2024
## [1.7.2](eslint-plugin-dialtone/v1.7.1...eslint-plugin-dialtone/v1.7.2) (2024-09-11) ### Bug Fixes * **Lint:** NO-JIRA fix linter rule for text styles ([#494](#494)) ([c6b5f3f](c6b5f3f))
juliodialpad
pushed a commit
that referenced
this pull request
Sep 12, 2024
# [9.73.0-beta.2](dialtone/v9.73.0-beta.1...dialtone/v9.73.0-beta.2) (2024-09-12) ### Bug Fixes * **Lint:** NO-JIRA fix linter rule for text styles ([#494](#494)) ([c6b5f3f](c6b5f3f)) * **Scrollbar Directive:** NO-JIRA overlayscrollbars missing styles ([#493](#493)) ([d1a88e1](d1a88e1)) * **Tokens:** NO-JIRA keep references in css output ([#487](#487)) ([b019ff6](b019ff6)) ### Documentation * **Icon:** DLT-1916 update documentation to show tree shaking examples ([#491](#491)) ([5b9d969](5b9d969)) * NO-JIRA wrong dialtone-css import on local ([da5f7d6](da5f7d6)) ### Features * **Avatar:** DLT-1916 remove dt-icon from Avatar vue 2 ([#474](#474)) ([e8600c3](e8600c3)) * **Feed Item Pill:** DLT-1916 remove dt-icon from Feed Item Pill ([#489](#489)) ([bde73c8](bde73c8)) * **Message Input:** DLT-1916 remove dt-icon from message input ([#490](#490)) ([3215116](3215116)) * **Utilities:** DLT-1763 add gap utility class ([#492](#492)) ([835d06f](835d06f))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix recommend-typography-style rule false positives
In this rule we were checking for
d-fwandd-ffprefixes, which are also used for flex-wrap and flex-flow properties.I improved the rule to target the specific properties to avoid getting a warning in those cases.