Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: DLT-1941 add dialtone combinator package #498

Merged
merged 12 commits into from
Nov 1, 2024
Merged

chore: DLT-1941 add dialtone combinator package #498

merged 12 commits into from
Nov 1, 2024

Conversation

juliodialpad
Copy link
Collaborator

@juliodialpad juliodialpad commented Sep 13, 2024 •
edited
Loading

Add Dialtone Combinator package to monorepo

Obligatory GIF (super important!)

Obligatory GIF

🛠️ Type Of Change

These types will not increment the version number, but will still deploy to documentation site on release:

  • Other (chore)

📖 Jira Ticket

https://dialpad.atlassian.net/browse/DLT-1941

📖 Description

  • Moved combinator package to the monorepo
  • Fixed some issues with dependencies version to be able to commit
  • Added combinator files to .markdownlintignore and .stylelintignore
  • This should not interfere with any other package/library on our monorepo, just wanted to move here and have it ready so I can use our local packages in an easier/faster way.

💡 Context

Starting the investigation to make the dialtone-combinator work on our documentation site.

📝 Checklist

For all PRs:

  • I have ensured no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
  • I have reviewed my changes.
  • I have added all relevant documentation.
  • I have considered the performance impact of my change.

For all Vue changes:

  • I have added / updated unit tests.
  • I have made my changes in Vue 2 and Vue 3. Note: you may sync your changes from Vue 2 to Vue 3 (or vice versa) using the ./scripts/dialtone-vue-sync.sh script. Read docs here: Dialtone Vue Sync Script
  • I have validated components with a screen reader.
  • I have validated components keyboard navigation.

For all CSS changes:

  • I have used design tokens whenever possible.
  • I have considered how this change will behave on different screen sizes.
  • I have visually validated my change in light and dark mode.
  • I have used gap or flexbox properties for layout instead of margin whenever possible.

If new component:

  • I am exporting any new components or constants:
    • from the index.js in the component directory.
    • from the index.js in the root (either packages/dialtone-vue2 or packages/dialtone-vue3).
  • I have added the styles for the new component to the packages/dialtone-css package.
  • I have created a page for the new component on the documentation site in apps/dialtone-documentation.
  • I have added the new component to common/components_list.js
  • I have created a component story in storybook
  • I have created story / stories for any relevant component variants in storybook
  • I have created a docs page for the component in storybook.
  • I have checked that changing all props/slots via the UI in storybook works as expected.

🔮 Next Steps

  • Keep investigating how to make the dialtone-combinator work with our latest library versions.

@juliodialpad
add dt-combinator package
356f829 
Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>
@juliodialpad juliodialpad added the no-visual-test Add this tag when the PR does not need visual testing label Sep 13, 2024
@juliodialpad juliodialpad self-assigned this Sep 13, 2024
@socket-security Socket Security
Copy link

socket-security bot commented Sep 13, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@vitejs/plugin-vue@5.1.3 environment 0 192 kB vitebot
npm/@vue/cli-plugin-unit-mocha@5.0.8 environment Transitive: filesystem, network +3 148 kB soda

🚮 Removed packages: npm/@vitejs/plugin-vue@5.0.4

View full report↗︎

@juliodialpad juliodialpad added visual-test-ready Add this tag when the PR is ready for visual test, to trigger GHA visual tests and removed no-visual-test Add this tag when the PR does not need visual testing labels Sep 13, 2024
@juliodialpad juliodialpad marked this pull request as draft September 18, 2024 16:36
@juliodialpad
build(combinator): DLT-2046 DLT-2047 update bundler and dependencies (#…
6d0e91e 
…500)

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>
@juliodialpad
add dt-combinator package
12be53f 
Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>
@juliodialpad
build(combinator): DLT-2046 DLT-2047 update bundler and dependencies (#…
4f5949a 
…500)

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>
@juliodialpad
update pnpm-lock
95556c8 
Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>
@juliodialpad
Merge remote-tracking branch 'origin/add_dt-combinator_package' into …
7087beb 
…add_dt-combinator_package

# Conflicts:
#	pnpm-lock.yaml
@juliodialpad juliodialpad mentioned this pull request Oct 1, 2024
Merged
3 tasks
@juliodialpad
chore: DLT-1942 combinator POC (#513)
ef784d1 
Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>
@braddialpad
Copy link
Contributor

This should be good to merge when ready as I believe all the code has already been reviewed. Just have to hide the implementation into the docsite, and not run any of the tests for combinator until they are working / migrated.

@juliodialpad
temporarily disable eslint
38fc983 
Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>
@juliodialpad
Merge branch 'staging' into add_dt-combinator_package
95ed71d 
# Conflicts:
#	pnpm-lock.yaml
@juliodialpad
enable eslint
cae438c 
Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>
@juliodialpad
hide combinator temporarily
bacf5ea 
Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>
@juliodialpad juliodialpad marked this pull request as ready for review November 1, 2024 18:50
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-498/
😎 Dialtone-vue 2 preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-498/
😎 Dialtone-vue 3 the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-498/

@juliodialpad juliodialpad merged commit 772b4b7 into staging Nov 1, 2024
6 checks passed
@juliodialpad juliodialpad deleted the add_dt-combinator_package branch November 1, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braddialpad braddialpad braddialpad approved these changes

@iropolo iropolo Awaiting requested review from iropolo iropolo is a code owner

@francisrupert francisrupert Awaiting requested review from francisrupert francisrupert is a code owner

@ninamarina ninamarina Awaiting requested review from ninamarina ninamarina is a code owner

Assignees

@juliodialpad juliodialpad

Labels
visual-test-ready Add this tag when the PR is ready for visual test, to trigger GHA visual tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliodialpad @braddialpad