fix: DLT-2036 conflicting peer dependencies #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>
juliodialpad
requested review from
iropolo,
francisrupert,
braddialpad and
ninamarina
as code owners
juliodialpad
added
the
no-visual-test
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@vitejs/plugin-vue@5.0.4 |
braddialpad
approved these changes
Oct 8, 2024
Yeah, that'd make our life a lot easier. |
juliodialpad
pushed a commit
that referenced
this pull request
Oct 9, 2024
## [9.79.1](dialtone/v9.79.0...dialtone/v9.79.1) (2024-10-09) ### Bug Fixes * DLT-2036 conflicting peer dependencies ([#526](#526)) ([e6b5105](e6b5105)) * **Rich Text Editor:** DLT-2120 toggle editable prop removes input class styles ([#527](#527)) ([3f31e7a](3f31e7a)) ### Documentation * DLT-1797 move SB to docs - Popover to Root Layout ([#521](#521)) ([511b135](511b135)) * DLT-2002 fix remaining modal scrollbar issues ([#519](#519)) ([cd0b1a5](cd0b1a5))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove conflicting peer dependencies
Obligatory GIF (super important!)
🛠️ Type Of Change
These types will increment the version number on release:
📖 Jira Ticket
https://dialpad.atlassian.net/browse/DLT-2036
📖 Description
@dialpad/dialtone@9.79.0-beta.1, you can install that version to check that everything is working correctly.This is not a solution I specially like as we might get some errors related to versions of the removed peerDependencies, BUT as we're having multiple packages that work on either vue2 or vue3 versions it's the fastest solution I could get.
The other solution that might work could be to alias the vue2 version but we're going to need to do that everywhere through all our projects that need vue2 (this is just an idea, I'm not actually sure that works)
💡 Context
Installing the @dialpad/dialtone package with
npmwas getting an error about conflicting vue versions.This was related to our package having peer dependencies that needed
vue@2(@tiptap/vue-2) along withvue@3(@tiptap/vue-3).PNPM can handle this correctly as we have some configs and overrides on root's
package.json.📝 Checklist
For all PRs: