fix(rich-text-editor): DLT-2120 toggle editable prop removes input class styles #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emariotti3
requested review from
juliodialpad,
iropolo,
francisrupert,
braddialpad and
ninamarina
as code owners
|
Please add either the |
|
✔️ Deploy previews ready! |
braddialpad
approved these changes
Oct 8, 2024
braddialpad
added
the
no-visual-test
juliodialpad
pushed a commit
that referenced
this pull request
Oct 9, 2024
## [9.79.1](dialtone/v9.79.0...dialtone/v9.79.1) (2024-10-09) ### Bug Fixes * DLT-2036 conflicting peer dependencies ([#526](#526)) ([e6b5105](e6b5105)) * **Rich Text Editor:** DLT-2120 toggle editable prop removes input class styles ([#527](#527)) ([3f31e7a](3f31e7a)) ### Documentation * DLT-1797 move SB to docs - Popover to Root Layout ([#521](#521)) ([511b135](511b135)) * DLT-2002 fix remaining modal scrollbar issues ([#519](#519)) ([cd0b1a5](cd0b1a5))
juliodialpad
pushed a commit
that referenced
this pull request
Oct 9, 2024
## [2.163.1](dialtone-vue2/v2.163.0...dialtone-vue2/v2.163.1) (2024-10-09) ### Bug Fixes * **Rich Text Editor:** DLT-2120 toggle editable prop removes input class styles ([#527](#527)) ([3f31e7a](3f31e7a)) ### Documentation * DLT-1797 move SB to docs - Popover to Root Layout ([#521](#521)) ([511b135](511b135)) * DLT-2002 fix remaining modal scrollbar issues ([#519](#519)) ([cd0b1a5](cd0b1a5))
juliodialpad
pushed a commit
that referenced
this pull request
Oct 9, 2024
## [3.156.1](dialtone-vue3/v3.156.0...dialtone-vue3/v3.156.1) (2024-10-09) ### Bug Fixes * **Rich Text Editor:** DLT-2120 toggle editable prop removes input class styles ([#527](#527)) ([3f31e7a](3f31e7a)) ### Documentation * DLT-1797 move SB to docs - Popover to Root Layout ([#521](#521)) ([511b135](511b135)) * DLT-2002 fix remaining modal scrollbar issues ([#519](#519)) ([cd0b1a5](cd0b1a5))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(rich-text-editor): DLT-2120 toggle editable prop removes input class styles
Obligatory GIF (super important!)
🛠️ Type Of Change
These types will increment the version number on release:
These types will not increment the version number, but will still deploy to documentation site on release:
📖 Jira Ticket
DLT-2120
📖 Description
Modified updateEditorAttributes method in rich text editor to preserve input class when updated on editable prop toggled.
💡 Context
This fix was needed because it was causing the font to shrink and certain styles to be removed when changing the value of the editable prop (while email was being sent) which looks strange. Linking a video here where I reproduce this issue in the Dialtone docs.
📝 Checklist
For all PRs:
For all Vue changes:
./scripts/dialtone-vue-sync.shscript. Read docs here: Dialtone Vue Sync Script📷 Screenshots / GIFs
Recording of issue fixed with changes applied locally.