Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rich-text-editor, editor): DLT-2175 editor loses text formatting while pasting #543

Merged

Conversation

emariotti3
Copy link
Contributor

@emariotti3 emariotti3 commented Oct 24, 2024

fix(rich-text-editor, editor): DLT-2175 editor loses text formatting while pasting

Obligatory GIF (super important!)

Obligatory GIF

🛠️ Type Of Change

These types will increment the version number on release:

  • Fix
  • Feature
  • Performance Improvement
  • Refactor

📖 Jira Ticket

https://dialpad.atlassian.net/browse/DLT-2175
https://dialpad.atlassian.net/browse/DP-115096

📖 Description

The email composer does not retain formatting while pasting a text.

💡 Context

Urgent fix required: the email composer does not retain formatting while pasting a text.
For now we're just passing a prop to override custom handler to fix this urgently and allow formatting to be preserved.
Property is set to default false to avoid breaking backwards compatibility.
We need to come up with a fix that tackles the break issue but also preserves formatting on paste for future release.

📝 Checklist

For all PRs:

  • I have ensured no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
  • I have reviewed my changes.
  • I have added all relevant documentation.
  • I have considered the performance impact of my change.

For all Vue changes:

  • I have added / updated unit tests.
  • I have made my changes in Vue 2 and Vue 3. Note: you may sync your changes from Vue 2 to Vue 3 (or vice versa) using the ./scripts/dialtone-vue-sync.sh script. Read docs here: Dialtone Vue Sync Script
  • I have validated components with a screen reader.
  • I have validated components keyboard navigation.

🔮 Next Steps

We need to remove this parameter in the future and analyze how to both:

  • preserve formatting on paste
  • preserve breaks/double breaks when pasting

📷 Screenshots / GIFs

Video evidence of fix here

Copy link

Please add either the visual-test-ready or no-visual-test label to this PR depending on whether you want to run visual tests or not.
It is recommended to run visual tests if your PR changes any UI. ‼️

@emariotti3 emariotti3 changed the title fix(rich-text-editor, editor): editor loses text formatting while pasting fix(rich-text-editor, editor): DLT-2175 editor loses text formatting while pasting Oct 24, 2024
Copy link

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-543/
😎 Dialtone-vue 2 preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-543/
😎 Dialtone-vue 3 the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-543/

@emariotti3 emariotti3 merged commit fd719a4 into staging Oct 24, 2024
10 of 12 checks passed
@emariotti3 emariotti3 deleted the DLT-2175-editor-loses-text-formatting-while-pasting branch October 24, 2024 23:20
braddialpad pushed a commit that referenced this pull request Oct 25, 2024
…while pasting (#543)

Co-authored-by: Eugenia Mariotti <eugenia.mariotti@dialpad.com>
juliodialpad pushed a commit that referenced this pull request Oct 30, 2024
## [9.81.1](dialtone/v9.81.0...dialtone/v9.81.1) (2024-10-24)

### Bug Fixes

* **Rich Text Editor, Editor:** DLT-2175 editor loses text formatting while pasting ([#543](#543)) ([fd719a4](fd719a4))
juliodialpad pushed a commit that referenced this pull request Oct 30, 2024
## [2.164.2](dialtone-vue2/v2.164.1...dialtone-vue2/v2.164.2) (2024-10-24)

### Bug Fixes

* **Rich Text Editor, Editor:** DLT-2175 editor loses text formatting while pasting ([#543](#543)) ([fd719a4](fd719a4))
juliodialpad pushed a commit that referenced this pull request Oct 30, 2024
## [3.157.2](dialtone-vue3/v3.157.1...dialtone-vue3/v3.157.2) (2024-10-24)

### Bug Fixes

* **Rich Text Editor, Editor:** DLT-2175 editor loses text formatting while pasting ([#543](#543)) ([fd719a4](fd719a4))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants