Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icon): DLT-2145 added Workforce Management (née Surfboard) #548

Merged
merged 4 commits into from
Oct 30, 2024

Conversation

fede-dp
Copy link
Contributor

@fede-dp fede-dp commented Oct 30, 2024

DLT-2145 new icon WFM v2

Obligatory GIF (super important!)

Obligatory GIF

🛠️ Type Of Change

These types will increment the version number on release:

  • Fix
  • Feature
  • Performance Improvement
  • Refactor

These types will not increment the version number, but will still deploy to documentation site on release:

  • Documentation
  • Build system
  • CI
  • Style (code style changes, not css changes)
  • Test
  • Other (chore)

📖 Jira Ticket

📖 Description

💡 Context

📝 Checklist

For all PRs:

  • I have ensured no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
  • I have reviewed my changes.
  • I have added all relevant documentation.
  • I have considered the performance impact of my change.

📷 Screenshots / GIFs

image

🔗 Sources

Copy link

Please add either the visual-test-ready or no-visual-test label to this PR depending on whether you want to run visual tests or not.
It is recommended to run visual tests if your PR changes any UI. ‼️

@fede-dp fede-dp added the no-visual-test Add this tag when the PR does not need visual testing label Oct 30, 2024
Copy link
Contributor

@francisrupert francisrupert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, though with the changes below.

packages/dialtone-icons/src/keywords-icons.json Outdated Show resolved Hide resolved
packages/dialtone-icons/src/keywords-icons.json Outdated Show resolved Hide resolved
@francisrupert francisrupert changed the title feat(icon): DLT-2145 new icon WFM v2 feat(icon): DLT-2145 added Workforce Management (née Surfboard) Oct 30, 2024
@francisrupert
Copy link
Contributor

@fede-dp While you're still in here can you move dialpad-sparkle from brand to brand-full-color category.

image

Copy link

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-548/
😎 Dialtone-vue 2 preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-548/
😎 Dialtone-vue 3 the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-548/

@fede-dp fede-dp merged commit 967d3e5 into staging Oct 30, 2024
6 checks passed
@fede-dp fede-dp deleted the DLT-2145-NewiconWFMv2 branch October 30, 2024 15:23
francisrupert pushed a commit that referenced this pull request Nov 1, 2024
# [9.83.0](dialtone/v9.82.0...dialtone/v9.83.0) (2024-10-30)

### Bug Fixes

* **Emoji Text Wrapper:** DLT-2176 invalid regular expression error ([#544](#544)) ([1ea0986](1ea0986))

### Features

* **Emoji Picker:** DP-113112 add shift key info on selected-emoji event ([#549](#549)) ([3092584](3092584))
* **Icon:** DLT-2145 added Workforce Management (née Surfboard) ([#548](#548)) ([967d3e5](967d3e5))
francisrupert pushed a commit that referenced this pull request Nov 1, 2024
# [4.29.0](dialtone-icons/v4.28.0...dialtone-icons/v4.29.0) (2024-10-30)

### Features

* **Icon:** DLT-2145 added Workforce Management (née Surfboard) ([#548](#548)) ([967d3e5](967d3e5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-visual-test Add this tag when the PR does not need visual testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants