Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tooltip): NO-JIRA inline css for tippy arrow #575

Merged
merged 1 commit into from
Nov 27, 2024
Merged

fix(tooltip): NO-JIRA inline css for tippy arrow #575

merged 1 commit into from
Nov 27, 2024

Conversation

braddialpad
Copy link
Contributor

fix(tooltip): inline css for tippy arrow

🛠️ Type Of Change

These types will increment the version number on release:

  • Fix

📖 Description

missed inlining the tippy arrow css, causes a build error otherwise

@braddialpad braddialpad self-assigned this Nov 27, 2024
@github-actions GitHub Actions
Copy link

Please add either the visual-test-ready or no-visual-test label to this PR depending on whether you want to run visual tests or not.
It is recommended to run visual tests if your PR changes any UI. ‼️

@braddialpad braddialpad changed the title fix(tooltip): inline css for tippy arrow fix(tooltip): NO-JIRA inline css for tippy arrow Nov 27, 2024
@braddialpad braddialpad added the no-visual-test Add this tag when the PR does not need visual testing label Nov 27, 2024
@github-actions GitHub Actions
Copy link

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-575/
😎 Dialtone-vue 2 preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-575/
😎 Dialtone-vue 3 the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-575/

@braddialpad braddialpad merged commit 09c8f8e into staging Nov 27, 2024
9 of 10 checks passed
@braddialpad braddialpad deleted the fix-tippy-arrow branch November 27, 2024 23:58
juliodialpad pushed a commit that referenced this pull request Nov 28, 2024
@semantic-release-bot
chore(release): NO-JIRA dialtone/v9.86.0
c07ff46 
# [9.86.0](dialtone/v9.85.2...dialtone/v9.86.0) (2024-11-28)

### Bug Fixes

* **Tooltip:** NO-JIRA inline css for tippy arrow ([#575](#575)) ([09c8f8e](09c8f8e))

### Features

* **Message Input:** DLT-2128 avoid closing the emoji picker when shift is pressed ([#570](#570)) ([285c7ee](285c7ee))
juliodialpad pushed a commit that referenced this pull request Nov 28, 2024
@semantic-release-bot
chore(release): NO-JIRA dialtone-css/v8.46.2
1ef5870 
## [8.46.2](dialtone-css/v8.46.1...dialtone-css/v8.46.2) (2024-11-28)

### Bug Fixes

* **Tooltip:** NO-JIRA inline css for tippy arrow ([#575](#575)) ([09c8f8e](09c8f8e))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliodialpad juliodialpad Awaiting requested review from juliodialpad juliodialpad is a code owner

@iropolo iropolo Awaiting requested review from iropolo iropolo is a code owner

@francisrupert francisrupert Awaiting requested review from francisrupert francisrupert is a code owner

@ninamarina ninamarina Awaiting requested review from ninamarina ninamarina is a code owner

Assignees

@braddialpad braddialpad

Labels
no-visual-test Add this tag when the PR does not need visual testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@braddialpad