fix(callbar_button): DLT-2122 css cleanup #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braddialpad
added
the
visual-test-ready
braddialpad
requested review from
juliodialpad,
iropolo,
francisrupert and
ninamarina
as code owners
iropolo
approved these changes
Dec 10, 2024
iropolo
reviewed
Dec 10, 2024
| @@ -27,7 +27,7 @@ | |||
| .d-recipe-callbar-button--active, | |||
| .d-recipe-callbar-button--active:hover { | |||
| .base-button__icon { | |||
| color: var(--primary-color); | |||
| color: var(--dt-theme-mention-color-background); // best replacement for --primary-color we have at the moment | |||
|
✔️ Deploy previews ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(callbar_button): css cleanup
🛠️ Type Of Change
These types will increment the version number on release:
📖 Jira Ticket
https://dialpad.atlassian.net/browse/DLT-2122
📖 Description
CSS recipe cleanup with the primary goal being to remove as much nested CSS as possible, and use proper BEM naming conventions (no double __ for example).