-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hovercard): DP-119841 hovercard fixes for Fast Connect #597
Conversation
29adfc9
to
cf13990
Compare
cf13990
to
29d3f4c
Compare
73f9a04
to
4d63dd2
Compare
4d63dd2
to
9ff9689
Compare
Please add either the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hovercard changes look good, please check my comment about the popover changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like using 'hovercard' for naming stuff inside popover
component makes me feel like we're mixing two components, Hovercard should be extending the popover, but we shouldn't need to modify the popover itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be possible to pass in listeners from the hovercard component and then use v-sync / v-model to manage the "open" prop. Let me know if there is some blocker I am not seeing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely agree. I will do those changes in this ticket https://dialpad.atlassian.net/browse/DLT-2245
Don't forgot to update the docs on the HoverCard component page |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with you merging this and then fixing it later since this works, and is probably a blocker for your launch-a-thon team, but I agree with @juliodialpad that it would be ideal to have all hovercard logic in the hovercard component and we should try to do that. I realize popover is a very complicated component and it might take a while.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be possible to pass in listeners from the hovercard component and then use v-sync / v-model to manage the "open" prop. Let me know if there is some blocker I am not seeing.
βοΈ Deploy previews ready! |
I created this ticket and added it to the next sprint: https://dialpad.atlassian.net/browse/DLT-2245. Thanks! |
Created a ticket to address the suggestions
# [9.92.0](dialtone/v9.91.1...dialtone/v9.92.0) (2024-12-18) ### Features * **Hovercard:** DP-119841 hovercard fixes for Fast Connect ([#597](#597)) ([e5c78a3](e5c78a3))
# [2.170.0](dialtone-vue2/v2.169.1...dialtone-vue2/v2.170.0) (2024-12-18) ### Features * **Hovercard:** DP-119841 hovercard fixes for Fast Connect ([#597](#597)) ([e5c78a3](e5c78a3))
# [3.163.0](dialtone-vue3/v3.162.1...dialtone-vue3/v3.163.0) (2024-12-18) ### Features * **Hovercard:** DP-119841 hovercard fixes for Fast Connect ([#597](#597)) ([e5c78a3](e5c78a3))
Hovercard fixes for Fast Connect
π οΈ Type Of Change
These types will increment the version number on release:
π Jira Ticket
DP-119841
π Description
Some features needed for Fast Connect, and a bug fix.
Adds "open" prop to Hovercard, to allow to programmatically open / close the hovercard, works like the "open" prop for the Popover component
Fixes a bug that happened when hovering mentions that are close.
To fix this I removed the special behavior for the timer, that when changing from one hovercard to another would reduce the delay. I think it doesn't have a noticeable impact for the user and it was causing the hovercard to change to another one when passing through a mention, making it imposible to access the buttons for this case:
enterDelay
andleaveDelay
paramsπ‘ Context
This is for the Launchathon of Fast Connect: https://www.figma.com/design/gOHiwlDi8bkaV2rkDeR0NP/Fast-Connect?node-id=4921-60460&p=f&t=8uDpFPXJuc88aZzI-0