Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fst 20221118 https://dialpad.atlassian.net/browse/DP-60739 #5

Open
wants to merge 67 commits into
base: dev
Choose a base branch
from

Conversation

hassan-dialpad
Copy link

Please report changes to metadata to the upstream libphonenumber
project rather than here.

Do not send pull requests with changes in files under any of the following directories:

  • resources/
  • python/phonenumbers/data/
  • python/phonenumbers/carrierdata/
  • python/phonenumbers/shortdata/
  • python/phonenumbers/geodata/
  • python/phonenumbers/tzdata/

All of these directories hold code that is autogenerated from the metadata in the resources/ directory, which is an
exact copy of the equivalent directory in the
upstream project.

daviddrysdale and others added 30 commits February 25, 2022 07:29
Includes changes in resources/ up to and including
upstream commit 41b0976dcf35:
  "[maven-release-plugin] prepare release v8.12.44"
Includes changes in resources/ up to and including
upstream commit 0ea664e5e89d:
  "[maven-release-plugin] prepare release v8.12.45"
Includes changes in resources/ up to and including
upstream commit 3b8e317bc7e7:
  "[maven-release-plugin] prepare release v8.12.46"
Includes changes in resources/ up to and including
upstream commit e43c69d31a1d:
  "[maven-release-plugin] prepare release v8.12.47"
Add analogues of new upstream tests, with somewhat different
behaviour because metadata loading is different.
Includes changes in resources/ up to and including
upstream commit 4e7922d02168:
  "[maven-release-plugin] prepare release v8.12.48"
Includes changes in resources/ up to and including
upstream commit 0815b3b99811:
  "[maven-release-plugin] prepare release v8.12.49"
Includes changes in resources/ up to and including
upstream commit e1c6752b3585:
  "[maven-release-plugin] prepare release v8.12.50"
Includes changes in resources/ up to and including
upstream commit 80683407f4cb:
  "[maven-release-plugin] prepare release v8.12.51"
Includes changes in resources/ up to and including
upstream commit 011d35d28fe8:
  "[maven-release-plugin] prepare release v8.12.52"
daviddrysdale and others added 30 commits August 19, 2022 18:21
Includes changes in resources/ up to and including
upstream commit e6ecaf8566bd:
  "[maven-release-plugin] prepare release v8.12.54"
Includes changes in resources/ up to and including
upstream commit 6e35ecd929cf:
  "[maven-release-plugin] prepare release v8.12.55"
Includes changes in resources/ up to and including
upstream commit 222e5a8b3650:
  "[maven-release-plugin] prepare release v8.12.56"
Includes changes in resources/ up to and including
upstream commit 4c8898be71d2:
  "[maven-release-plugin] prepare release v8.12.57"
Includes changes in resources/ up to and including
upstream commit 185004cabd1b:
  "[maven-release-plugin] prepare release v8.13.0"
The clean target relies on the coverage tool being installed.
Summary: TEL-12621 - Unable dial new Poland Police prefix +48 47 731 4848

Test Plan: added

Reviewers: jerin

Differential Revision: https://phabricator.fspot.us/D14990
Summary:
Picked these regex changes from the build branch of Google. https://github.com/google/libphonenumber/blob/bc215578007c2a985a37f20597a5067744dca6b9/javascript/i18n/phonenumbers/metadatalite.js
The changes will take time to make it through the google release and the david's phone numbers lib. For the migration on Jan 31st we need to push this lib changes for the numbers to be edited and added on product

Test Plan: NA

Reviewers: nick, jerin

Reviewed By: nick

Differential Revision: https://phabricator.fspot.us/D15409
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants