Fix gitpod node/npm version (#598) #207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See merged PR on deso frontend
@superzordon
Prior to the April commit - the gitpod button would launch frontend repo fine in gitpod. But since lockfile was switched to v2 - this broke.
This PR fixes that by customising the docker build used by gitpod and installing node 14.15.5 and npm 7.
Here is the easy gitpod link to test this PR:
GitPod link to test PR
If needed, login to gitpod
Preview window always uses preview domain for the Node. So to login to frontend, you need to set the correct lastLocalNodeV2 to "https://api.tijn.club/" in your browser Local Storage for the gitpod preview URL.