Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links to Explainable embeddings #868

Merged
merged 6 commits into from
Nov 13, 2024
Merged

Links to Explainable embeddings #868

merged 6 commits into from
Nov 13, 2024

Conversation

elboyran
Copy link
Contributor

@elboyran elboyran commented Nov 7, 2024

  • Link to the RSD page for the explainable embedding software.
  • Update the roadmap.
  • Update documentation

Added link to the RSD page for the explainable embedding software.
@elboyran elboyran changed the title Update README.md Links to Explainable embeddings Nov 7, 2024
@elboyran elboyran self-assigned this Nov 7, 2024
@elboyran elboyran added the documentation Improvements or additions to documentation label Nov 7, 2024
Added embedding in the key points.
Remove the embeddings, update the plans (if ever funding is found...)
@elboyran elboyran requested a review from cwmeijer November 7, 2024 14:59
@elboyran elboyran marked this pull request as ready for review November 7, 2024 15:01
@elboyran
Copy link
Contributor Author

elboyran commented Nov 7, 2024

I've also updated the RSD software page.

@elboyran elboyran marked this pull request as draft November 7, 2024 15:10
@elboyran
Copy link
Contributor Author

elboyran commented Nov 7, 2024

Updated documentation link

@elboyran elboyran marked this pull request as ready for review November 7, 2024 15:28
Copy link
Member

@cwmeijer cwmeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the link! I corrected the link to the repo and did a textual suggestion.

README.md Outdated Show resolved Hide resolved
docs/ROADMAP.md Outdated Show resolved Hide resolved
elboyran and others added 2 commits November 11, 2024 13:53
Co-authored-by: Christiaan Meijer <c.meijer@esciencecenter.nl>
Co-authored-by: Christiaan Meijer <c.meijer@esciencecenter.nl>
@elboyran elboyran requested a review from cwmeijer November 11, 2024 12:54
@@ -75,7 +75,7 @@ The key points of DIANNA:
* Implements well-known XAI methods LIME, RISE and KernelSHAP, chosen by systematic and objective evaluation criteria
* Comes with a dashboard where results of different explainers can be compared for all data types
* Supports the de-facto standard of neural network models - ONNX
* Supports images, text, time series, and tabular data modalities, embeddings are currently being developed
* Supports images, text, time series, tabular data modalities and embeddings (in a related [package](https://github.com/dianna-ai/explainable_embedding))
Copy link
Member

@cwmeijer cwmeijer Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Supports images, text, time series, tabular data modalities and embeddings (in a related [package](https://github.com/dianna-ai/explainable_embedding))
* Supports images, text, time series, tabular data modalities and embeddings (in a related package, [distance_explainer](https://github.com/dianna-ai/distance_explainer))

Copy link
Member

@cwmeijer cwmeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw one more link that needed updating to our distance_explainer repo (see suggestion/comment). Please commit that one as well before merging.
Thanks for this PR!

@elboyran elboyran requested a review from cwmeijer November 13, 2024 09:55
@elboyran elboyran merged commit 6cf8609 into main Nov 13, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants