Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RetroFW/OpenDingux: Enable networking #542

Closed
wants to merge 3 commits into from

Conversation

glebm
Copy link
Collaborator

@glebm glebm commented Jan 19, 2020

IMG_20200215_165537

This causes severe load time issues even in single player, leaving as a draft PR for future reference.

Update Single-player load time issues fixed , now just waiting for libsodium to be merged into the RG350 buildroot

Update Ready to merge!


These devices lack entropy immediately after startup and thus cannot initialize network encryption. You have to wiggle the sticks / press random buttons to join a network game.

@glebm glebm force-pushed the retrofw-network branch 2 times, most recently from 8b04c5a to 62345bb Compare January 19, 2020 22:58
@AJenbo
Copy link
Member

AJenbo commented Jan 20, 2020

Another issue that needs to be resolved is how to enter ip (could be added to the diablo.ini phonebook) and passwords from the handhelds.

@@ -7,6 +7,8 @@ set(SDL1_VIDEO_MODE_HEIGHT 240)

set(SDL1_VIDEO_MODE_BPP 16)
set(PREFILL_PLAYER_NAME ON)
set(MULTIPLAYER_DEFAULT_IP "\"10.1.1.1\"")
set(MULTIPLAYER_DEFAULT_PASSWORD "\"123\"")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting default IP and password at build time doesn't seam appropriate.

Copy link
Collaborator Author

@glebm glebm Feb 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There isn't another place to set defaults. The packages for these devices don't have an install step, they create an ini file at startup if one doesn't exist.

Alternatively, we could generate a random one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imo an onscreen keyboard is the right solution, that would also solve the issue of a missing input when splitting gold.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is what is being used for the Vita port: https://github.com/diasurgical/devilutionX/tree/4c2a43b23e92adcb1d047fdd52e10fb53c9471ff/vita/danzeffSDL maybe we can integrate that.

billede

Copy link
Collaborator Author

@glebm glebm Feb 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I have no interest in implementing that so will leave this to someone else.

There is an SDL1 virtual keyboard here:
https://github.com/glebm/rs97-commander/blob/upd2/keyboard.cpp
another one here:
https://github.com/benob/rs97_st-sdl/blob/master/keyboard.c

@glebm
Copy link
Collaborator Author

glebm commented Mar 17, 2021

Rebased, by popular request

This may be worth it even without virtual keyboard -- users can edit diablo.ini for now and this can help uncover other networking bugs

OPKs with this PR here: https://github.com/glebm/devilutionX/releases/tag/net-2021-03-16

@AJenbo
Copy link
Member

AJenbo commented Mar 17, 2021

1.3.0 will allow for games without passwords

@AJenbo AJenbo added this to the 1.3.0 milestone Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants