-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RetroFW/OpenDingux: Enable networking #542
Conversation
8b04c5a
to
62345bb
Compare
Another issue that needs to be resolved is how to enter ip (could be added to the diablo.ini phonebook) and passwords from the handhelds. |
62345bb
to
34e5f1f
Compare
8632722
to
a922dbd
Compare
a922dbd
to
b336b36
Compare
a57e146
to
f575781
Compare
@@ -7,6 +7,8 @@ set(SDL1_VIDEO_MODE_HEIGHT 240) | |||
|
|||
set(SDL1_VIDEO_MODE_BPP 16) | |||
set(PREFILL_PLAYER_NAME ON) | |||
set(MULTIPLAYER_DEFAULT_IP "\"10.1.1.1\"") | |||
set(MULTIPLAYER_DEFAULT_PASSWORD "\"123\"") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting default IP and password at build time doesn't seam appropriate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There isn't another place to set defaults. The packages for these devices don't have an install step, they create an ini file at startup if one doesn't exist.
Alternatively, we could generate a random one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imo an onscreen keyboard is the right solution, that would also solve the issue of a missing input when splitting gold.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is what is being used for the Vita port: https://github.com/diasurgical/devilutionX/tree/4c2a43b23e92adcb1d047fdd52e10fb53c9471ff/vita/danzeffSDL maybe we can integrate that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I have no interest in implementing that so will leave this to someone else.
There is an SDL1 virtual keyboard here:
https://github.com/glebm/rs97-commander/blob/upd2/keyboard.cpp
another one here:
https://github.com/benob/rs97_st-sdl/blob/master/keyboard.c
f575781
to
0683bfb
Compare
f43bc18
to
2439225
Compare
Rebased, by popular request This may be worth it even without virtual keyboard -- users can edit OPKs with this PR here: https://github.com/glebm/devilutionX/releases/tag/net-2021-03-16 |
1.3.0 will allow for games without passwords |
This causes severe load time issues even in single player, leaving as a draft PR for future reference.Update Single-player load time issues fixed
, now just waiting for libsodium to be merged into the RG350 buildrootUpdate Ready to merge!
These devices lack entropy immediately after startup and thus cannot initialize network encryption. You have to wiggle the sticks / press random buttons to join a network game.